[WIP] Implement .NET conformance testing #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
reviewed
Aug 7, 2024
| // We can't just go run the pulumi-test-language package because of | ||
| // https://github.com/golang/go/issues/39172, so we build it to a temp file then run that. | ||
| binary := t.TempDir() + "/pulumi-test-language" | ||
| cmd := exec.Command("go", "build", "-C", "../cmd/pulumi-test-language", "-o", binary) |
There was a problem hiding this comment.
So I'm pretty sure you can go build a git address so you don't need to clone it into the repo
Frassle
reviewed
Aug 7, 2024
pulumi-language-dotnet/main.go
Outdated
|
|
||
| cmd := exec.Command(host.exec, "pack", "-c", "Release", "-o", destination) | ||
| cmd.Dir = req.PackageDirectory | ||
| cmd.Env = os.Environ() |
Frassle
reviewed
Aug 7, 2024
pulumi-language-dotnet/main.go
Outdated
| } | ||
|
|
||
| return &pulumirpc.PackResponse{ | ||
| ArtifactPath: destination, |
There was a problem hiding this comment.
This should return the actual nuget file
Zaid-Ajaj
commented
Aug 7, 2024
Comment on lines
+928
to
+931
| } else if !versionsMatch(expectedDependency.Version, *found) && expectedDependency.Name != "pulumi" { | ||
| return makeTestResponse(fmt.Sprintf("dependency %s has unexpected version %s, expected %s", | ||
| expectedDependency.Name, *found, expectedDependency.Version)), nil | ||
| } |
There was a problem hiding this comment.
Here is where I made the change to exclude testing pulumi core sdk version, otherwise I didn't understand where the version was coming from since the nuget has v1.0.0
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation of .NET conformance tests. It extends pulumi-language-dotnet with
GenerateProject,GeneratePackageandPackThe actual tests require
pulumi-test-languagewhich is a command line Go tool from pulumi/pulumi. This I had to copy over using a new build commandsync-pulumi-test-language(I don't think we want to do this so we might need to publish it and consume it from here)It requires changes from pulumi/pulumi#16902 to correctly emit the paths and version of local dependencies.
There is a problem where the pulumi-test-language tries to assert the core sdk version but it doesn't match for some reason, so I had to disable this check for the
pulumidependency. I couldn't quite get where the version was retrieved from because when we pack Pulumi.csproj it doesn't have a version and defaults to 1.0.0 but the tests want a specific version that doesn't match (see below) cc @Frassle